[PATCH i-g-t v2 12/13] tests/intel: Unify functionality for compute tests

Katarzyna Piecielska katarzyna.piecielska at intel.com
Tue Mar 26 09:29:06 UTC 2024


Let's clean up functionality for Xe compute tests:

	s/compute machine/compute/ for xe_exec_compute_mode.c
	s/compute VM bind/VM bind/ for igt at xe_noexec_ping_pong.c
	s/compute openCL kernel/openCL kernel/ for xe_compute*.c
	s/ccs_mode user interface/ccs mode/ for xe_compute at ccs-mode-*

v2:  s/compute openCL kernel/OpenCL kernel/ for xe_compute*.c (Kamil)

Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
Cc: Mauro Carvalho Chehab <mauro.chehab at linux.intel.com>
Cc: Aditya Chauhan <aditya.chauhan at intel.com>
Cc: Girotra Himanshu <himanshu.girotra at intel.com>
Acked-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
---
 tests/intel/xe_compute.c           | 6 +++---
 tests/intel/xe_compute_preempt.c   | 6 +++---
 tests/intel/xe_exec_compute_mode.c | 2 +-
 tests/intel/xe_noexec_ping_pong.c  | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/intel/xe_compute.c b/tests/intel/xe_compute.c
index 9cf359383..e773e798a 100644
--- a/tests/intel/xe_compute.c
+++ b/tests/intel/xe_compute.c
@@ -44,7 +44,7 @@ static bool get_num_cslices(u32 gt, u32 *num_slices)
  * SUBTEST: ccs-mode-basic
  * GPU requirement: PVC
  * Description: Validate 'ccs_mode' sysfs uapi
- * Functionality: ccs_mode user interface
+ * Functionality: ccs mode
  */
 static void
 test_ccs_mode(int num_gt)
@@ -111,7 +111,7 @@ test_ccs_mode(int num_gt)
  * SUBTEST: ccs-mode-compute-kernel
  * GPU requirement: PVC
  * Description: Validate 'ccs_mode' by running compute kernel
- * Functionality: CCS mode funtionality
+ * Functionality: ccs mode
  */
 static void
 test_compute_kernel_with_ccs_mode(int num_gt)
@@ -158,7 +158,7 @@ test_compute_kernel_with_ccs_mode(int num_gt)
  * Description:
  *	Run an openCL Kernel that returns output[i] = input[i] * input[i],
  *	for an input dataset..
- * Functionality: compute openCL kernel
+ * Functionality: OpenCL kernel
  */
 static void
 test_compute_square(int fd)
diff --git a/tests/intel/xe_compute_preempt.c b/tests/intel/xe_compute_preempt.c
index 45aa15c78..b8448ef91 100644
--- a/tests/intel/xe_compute_preempt.c
+++ b/tests/intel/xe_compute_preempt.c
@@ -7,6 +7,7 @@
  * TEST: Check compute-related preemption functionality
  * Category: Hardware building block
  * Sub-category: Compute
+ * Functionality: OpenCL kernel
  * Test category: functionality test
  */
 
@@ -21,17 +22,16 @@
  * GPU requirement: LNL
  * Description:
  *      Exercise compute walker mid thread preemption scenario
- * Functionality: compute openCL kernel
+ *
  * SUBTEST: compute-preempt-many
  * GPU requirement: LNL
  * Description:
  *      Exercise multiple walker mid thread preemption scenario
- * Functionality: compute openCL kernel
+ *
  * SUBTEST: compute-threadgroup-preempt
  * GPU requirement: LNL
  * Description:
  *      Exercise compute walker threadgroup preemption scenario
- * Functionality: compute openCL kernel
  */
 static void
 test_compute_preempt(int fd, struct drm_xe_engine_class_instance *hwe, bool threadgroup_preemption)
diff --git a/tests/intel/xe_exec_compute_mode.c b/tests/intel/xe_exec_compute_mode.c
index c1f703c43..3ec848164 100644
--- a/tests/intel/xe_exec_compute_mode.c
+++ b/tests/intel/xe_exec_compute_mode.c
@@ -7,7 +7,7 @@
  * TEST: Basic tests for execbuf compute machine functionality
  * Category: Hardware building block
  * Sub-category: CMD submission
- * Functionality: compute machine
+ * Functionality: compute
  */
 
 #include <fcntl.h>
diff --git a/tests/intel/xe_noexec_ping_pong.c b/tests/intel/xe_noexec_ping_pong.c
index 51f28d9d0..f88f2af9d 100644
--- a/tests/intel/xe_noexec_ping_pong.c
+++ b/tests/intel/xe_noexec_ping_pong.c
@@ -19,7 +19,7 @@
  * TEST: Expose compute VM's unnecessary rebinds
  * Category: Hardware building block
  * Sub-category: Compute
- * Functionality: compute VM rebind
+ * Functionality: VM rebind
  * Test category: functionality test
  *
  * SUBTEST:
-- 
2.34.1



More information about the igt-dev mailing list