[PATCH i-g-t] lib/intel_ctx: Propagate error from __intel_ctx_xe_exec wait timeout

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Mon May 6 14:30:30 UTC 2024


Hey,

Den 2024-05-06 kl. 15:32, skrev Zbigniew Kempczyński:
> On Mon, May 06, 2024 at 02:08:27PM +0200, Maarten Lankhorst wrote:
>> Any wait timeouts are currently ignored, which might cause silent
>> failures in test. Be more noisy about them.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> ---
>>   lib/intel_ctx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/intel_ctx.c b/lib/intel_ctx.c
>> index b43dd6391..30325b906 100644
>> --- a/lib/intel_ctx.c
>> +++ b/lib/intel_ctx.c
>> @@ -450,7 +450,7 @@ int __intel_ctx_xe_exec(const intel_ctx_t *ctx, uint64_t ahnd, uint64_t bb_offse
>>   		goto err;
>>   
>>   	if (!ctx->sync_bind || !ctx->sync_out)
>> -		syncobj_wait_err(ctx->fd, &sync_out, 1, INT64_MAX, 0);
>> +		ret = syncobj_wait_err(ctx->fd, &sync_out, 1, INT64_MAX, 0);
>>   
>>   err:
>>   	if (!ctx->sync_bind)
>> -- 
>> 2.43.0
>>
> Yes, you're definitely right:
>
> Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
Thanks, pushed!


More information about the igt-dev mailing list