[PATCH i-g-t v3 00/12] gputop: Add support for xe

Lucas De Marchi lucas.demarchi at intel.com
Mon May 6 20:40:47 UTC 2024


On Mon, May 06, 2024 at 11:37:13AM GMT, Tvrtko Ursulin wrote:
>
>On 04/05/2024 07:46, Lucas De Marchi wrote:
>>v3 of https://lore.kernel.org/all/20240423234431.1959354-1-lucas.demarchi@intel.com
>>
>>I moved some gputop eye candy to a separate series:
>>https://lore.kernel.org/all/20240501173303.115737-1-lucas.demarchi@intel.com
>>
>>This now also moves all the refactors to come as prep patches. The
>>drm-total-cycles addition is  in the last 3 patches.
>>
>>As requested fdinfo and drm-clients libraries now don't take any
>>decision: they only read the fdinfo and calculate the deltas
>>respectively. The decision about what aproach to use to calculate the
>>client utilization is left to gputop.
>
>Approach LGTM so ack for the series. Hopefully someone else can do the 
>detailed review.
>
>Just two observations - 3/13 I don't know what the "fixup" is, 

my bad when fixing the previous patch and forgetting to really squash
that in the previous patch.

>supposed to be and 12/13 incorrectly mentions it is adding some assert 
>to intel_gpu_top.

I will reword that, thanks

Lucas De Marchi


More information about the igt-dev mailing list