[PATCH 2/4] gputop: Add option parsing

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue May 7 18:24:14 UTC 2024


Hi Lucas,
On 2024-05-01 at 12:33:01 -0500, Lucas De Marchi wrote:
> Add skeleton for option parsing, with just a -h/--help to be used
> for additional options later.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tools/gputop.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/tools/gputop.c b/tools/gputop.c
> index 7fd9e9790..481e79753 100644
> --- a/tools/gputop.c
> +++ b/tools/gputop.c
> @@ -292,11 +292,62 @@ static void clrscr(void)
>  	printf("\033[H\033[J");
>  }
>  
> +struct gputop_args {
> +};
> +
> +static void help(void)
> +{
> +	printf("Usage:\n"
> +	       "\t%s [options]\n\n"
> +	       "Options:\n"
> +	       "\t-h, --help                show this help\n"
> +	       , program_invocation_short_name);
> +}
> +
> +static int parse_args(int argc, char * const argv[], struct gputop_args *args)
> +{
> +	static const char cmdopts_s[] = "h";
> +	static const struct option cmdopts[] = {
> +	       {"help", no_argument, 0, 'h'},
> +	       { }
> +	};
> +
> +	/* defaults */
> +	memset(args, 0, sizeof(*args));
> +
> +	for (;;) {
> +		int c, idx = 0;
> +
> +		c = getopt_long(argc, argv, cmdopts_s, cmdopts, &idx);
> +		if (c == -1)
> +			break;
> +
> +		switch (c) {
> +		case 'h':
> +			help();
> +			return 0;
> +		default:
> +			fprintf(stderr, "Unkonwn option '%c'.\n", c);
> +			return -1;
> +		}
> +	}
> +
> +	return 1;
> +}
> +
>  int main(int argc, char **argv)
>  {
> +	struct gputop_args args;
>  	unsigned int period_us = 2e6;
>  	struct igt_drm_clients *clients = NULL;
>  	int con_w = -1, con_h = -1;
> +	int ret;
> +
> +	ret = parse_args(argc, argv, &args);
> +	if (ret < 0)
> +		return EXIT_FAILURE;
> +	if (!ret)
> +		return EXIT_SUCCESS;
>  
>  	clients = igt_drm_clients_init(NULL);
>  	if (!clients)
> -- 
> 2.45.0
> 


More information about the igt-dev mailing list