[PATCH i-g-t v3 06/11] lib/rendercopy_gen9: Allow to use all tilings on flatccs platforms

[Zbigniew Kempczyński]

On Tue, May 07, 2024 at 03:59:27PM +0300, Juha-Pekka Heikkila wrote:
> On 7.5.2024 10.58, Zbigniew Kempczyński wrote:
> > Instead of limiting compression to Tile4 lets enable it for any
> > tiling when platform has flatccs area. For integrated leave Tile4
> > condition to properly configure compression on those platforms.
> > 
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> > Reviewed-by: Karolina Stolarek <karolina.stolarek at intel.com>
> > ---
> >   lib/rendercopy_gen9.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
> > index 7c7563d50c..c73f815efc 100644
> > --- a/lib/rendercopy_gen9.c
> > +++ b/lib/rendercopy_gen9.c
> > @@ -268,7 +268,7 @@ gen9_bind_buf(struct intel_bb *ibb, const struct intel_buf *buf, int is_dst,
> >   			ss->ss13.clear_address_hi = (address + buf->cc.offset) >> 32;
> >   		}
> > -		if (HAS_4TILE(ibb->devid)) {
> > +		if (HAS_4TILE(ibb->devid) || HAS_FLATCCS(ibb->devid)) {
> 
> Is this change needed? What that HAS_4TILE checks here is if there is need
> to use members of below structure which are post dg2, hence named these
> members dg2. Currently all platforms to my knowledge that need to use these
> dg2 members are with tile4 but not all of them are having flatccs.

You're right, I didn't realize above condition also extends to Tile64.

Anyway I've noticed after checking documentation for xe2 r8g8b8a8
compression type is not 0x8 but 0x2. And looking at png on compressed
surface setting there to 0x2 gives better compression ratio.

Thanks for the review. I'm going to alter this patch and resend it.

--
Zbigniew

> 
> >   			ss->ss7.dg2.memory_compression_type = 0;
> >   			ss->ss7.dg2.memory_compression_enable = 0;
> >   			ss->ss7.dg2.disable_support_for_multi_gpu_partial_writes = 1;
>