[PATCH i-g-t] tests/intel: add some missing core tests to xe_test_config.json

[Kamil Konieczny]

Hi Mauro,
On 2024-05-08 at 11:49:31 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> Such tests are also used to check Xe functionality. Add them
> to the Xe testplan configuration.
> 
> Also, move descriptions for simple tests to the right place,
> as otherwise warnings will be produced:
> 	Warning: igt at core_getclient Description documentation is missing
> 	Warning: igt at core_getstats Description documentation is missing
> 	Warning: igt at core_setmaster_vs_auth Description documentation is missing
> 
> As each subtest requires its own description.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
> ---
>  tests/core_getclient.c          | 2 +-
>  tests/core_getstats.c           | 2 +-
>  tests/core_setmaster_vs_auth.c  | 2 +-

These are only 3 for total of 7 core tests, imho we should have them all.

>  tests/intel/xe_test_config.json | 4 +++-
>  4 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/core_getclient.c b/tests/core_getclient.c
> index 308f2c0e4422..6756c0882381 100644
> --- a/tests/core_getclient.c
> +++ b/tests/core_getclient.c
> @@ -34,13 +34,13 @@
>  /**
>   * TEST: core getclient
>   * Category: Desktop client
> - * Description: Tests the DRM_IOCTL_GET_CLIENT ioctl.

imho here you could just leave it (no deletion needed).
Or if you insist you could write a generic description
and use it in other tests:

 * Description: Tests core DRM_IOCTL_* ioctl.

>   * Feature: core
>   * Functionality: permission management for clients
>   * Sub-category: DRM
>   * Test category: GEM_Legacy
>   *
>   * SUBTEST:
> + * Description: Tests the DRM_IOCTL_GET_CLIENT ioctl
>   */
>  
>  IGT_TEST_DESCRIPTION("Tests the DRM_IOCTL_GET_CLIENT ioctl.");
> diff --git a/tests/core_getstats.c b/tests/core_getstats.c
> index b2d26a8260a9..6f98087253c7 100644
> --- a/tests/core_getstats.c
> +++ b/tests/core_getstats.c
> @@ -35,13 +35,13 @@
>  /**
>   * TEST: core getstats
>   * Category: Desktop client
> - * Description: Tests the DRM_IOCTL_GET_STATS ioctl.

Same here.

>   * Feature: core
>   * Functionality: DRM memory management
>   * Sub-category: uapi
>   * Test category: GEM_Legacy
>   *
>   * SUBTEST:
> + * Description: Tests the DRM_IOCTL_GET_STATS ioctl.
>   */
>  
>  /**
> diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c
> index 592d850f6bc5..c8fbc827b9f1 100644
> --- a/tests/core_setmaster_vs_auth.c
> +++ b/tests/core_setmaster_vs_auth.c
> @@ -43,13 +43,13 @@
>  /**
>   * TEST: core setmaster vs auth
>   * Category: Desktop client
> - * Description: Check that drop/setMaster correctly transfer master state

Same here.

>   * Feature: core
>   * Functionality: permission management for clients
>   * Sub-category: DRM
>   * Test category: GEM_Legacy
>   *
>   * SUBTEST:
> + * Description: Check that drop/setMaster correctly transfer master state
>   */
>  
>  IGT_TEST_DESCRIPTION("Check that drop/setMaster correctly transfer master "
> diff --git a/tests/intel/xe_test_config.json b/tests/intel/xe_test_config.json
> index 3775e63fc65e..ef3993dae8e5 100644
> --- a/tests/intel/xe_test_config.json
> +++ b/tests/intel/xe_test_config.json
> @@ -2,7 +2,9 @@
>      "description": "JSON file to be used to parse Xe documentation",
>      "name": "Tests for Xe Driver",
>      "drivers": [ "xe" ],
> -    "files": [ "xe_*.c", "../core_hotunplug.c", "../sriov_basic.c", "intel_hwmon.c" ],
> +    "files": [ "xe_*.c", "../core_hotunplug.c", "../sriov_basic.c", "intel_hwmon.c",

imho better: ../core_*.c

Regards,
Kamil

> +               "../core_auth.c", "../core_getclient.c", "../core_getstats.c",
> +               "../core_getversion.c", "../core_setmaster.c", "../core_setmaster_vs_auth.c" ],
>      "fields": {
>          "Run type": {
>              "_properties_": {
> -- 
> 2.44.0
>