[PATCH i-g-t v2] tests/intel: add other missing core tests to xe_test_config.json

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed May 8 10:37:44 UTC 2024


Hi Mauro,
On 2024-05-08 at 12:29:41 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> All core tests are used to check Xe functionality. Add them to the Xe
> testplan configuration.
> 
> Also, move descriptions for simple tests to the right place,
------- ^^^^
s/move/add/

With that,
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> as otherwise warnings will be produced:
> 	Warning: igt at core_getclient Description documentation is missing
> 	Warning: igt at core_getstats Description documentation is missing
> 	Warning: igt at core_setmaster_vs_auth Description documentation is missing
> 
> As each subtest requires its own description.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
> ---
>  tests/core_getclient.c          | 1 +
>  tests/core_getstats.c           | 1 +
>  tests/core_setmaster_vs_auth.c  | 1 +
>  tests/intel/xe_test_config.json | 2 +-
>  4 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/core_getclient.c b/tests/core_getclient.c
> index 308f2c0e4422..5914335724d3 100644
> --- a/tests/core_getclient.c
> +++ b/tests/core_getclient.c
> @@ -41,6 +41,7 @@
>   * Test category: GEM_Legacy
>   *
>   * SUBTEST:
> + * Description: Tests the DRM_IOCTL_GET_CLIENT ioctl.
>   */
>  
>  IGT_TEST_DESCRIPTION("Tests the DRM_IOCTL_GET_CLIENT ioctl.");
> diff --git a/tests/core_getstats.c b/tests/core_getstats.c
> index b2d26a8260a9..05e0eae34008 100644
> --- a/tests/core_getstats.c
> +++ b/tests/core_getstats.c
> @@ -42,6 +42,7 @@
>   * Test category: GEM_Legacy
>   *
>   * SUBTEST:
> + * Description: Tests the DRM_IOCTL_GET_STATS ioctl.
>   */
>  
>  /**
> diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c
> index 592d850f6bc5..4605f84530e4 100644
> --- a/tests/core_setmaster_vs_auth.c
> +++ b/tests/core_setmaster_vs_auth.c
> @@ -50,6 +50,7 @@
>   * Test category: GEM_Legacy
>   *
>   * SUBTEST:
> + * Description: Check that drop/setMaster correctly transfer master state
>   */
>  
>  IGT_TEST_DESCRIPTION("Check that drop/setMaster correctly transfer master "
> diff --git a/tests/intel/xe_test_config.json b/tests/intel/xe_test_config.json
> index 3775e63fc65e..6651c12073c6 100644
> --- a/tests/intel/xe_test_config.json
> +++ b/tests/intel/xe_test_config.json
> @@ -2,7 +2,7 @@
>      "description": "JSON file to be used to parse Xe documentation",
>      "name": "Tests for Xe Driver",
>      "drivers": [ "xe" ],
> -    "files": [ "xe_*.c", "../core_hotunplug.c", "../sriov_basic.c", "intel_hwmon.c" ],
> +    "files": [ "xe_*.c", "../core_*.c", "../sriov_basic.c", "intel_hwmon.c" ],
>      "fields": {
>          "Run type": {
>              "_properties_": {
> -- 
> 2.44.0
> 


More information about the igt-dev mailing list