[PATCH i-g-t] lib/i915/perf: Accumulate clocks for MPEC format too

Umesh Nerlige Ramappa umesh.nerlige.ramappa at intel.com
Fri May 10 20:25:56 UTC 2024


On Fri, May 10, 2024 at 10:04:50AM -0700, Ashutosh Dixit wrote:
>Clocks/gpu_ticks should also be accumulated in intel_perf_accumulate_reports.
>
>Fixes: cbe11c2939f8 ("lib/i915/perf: Add support for select MPEC formats")
>Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>

Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>

Thanks for catching and fixing this,
Umesh
>---
> lib/i915/perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/i915/perf.c b/lib/i915/perf.c
>index bbfa360607..9333edfebb 100644
>--- a/lib/i915/perf.c
>+++ b/lib/i915/perf.c
>@@ -928,7 +928,7 @@ void intel_perf_accumulate_reports(struct intel_perf_accumulator *acc,
> 			deltas[idx++] += (end64[1] - start64[1]) >> (-perf->devinfo.oa_timestamp_shift);
>
> 		/* 64 bit clock */
>-		deltas[idx++] = end64[3] - start64[3];
>+		deltas[idx++] += end64[3] - start64[3];
>
> 		/* 8x 32bit MPEC counters */
> 		for (i = 0; i < 8; i++)
>-- 
>2.41.0
>


More information about the igt-dev mailing list