[PATCH] tests/kms_writeback: refresh to expose writeback output
Abhinav Kumar
quic_abhinavk at quicinc.com
Mon May 13 21:48:44 UTC 2024
On 5/13/2024 2:30 PM, Alex Hung wrote:
> With dc2d7fb4f978, all kms_writeback subtests are skipped.
>
> Refresh the outputs to grab all supported connectors,
> the writeback output that is just enabled.
>
Can you please help to explain how the tests are getting skipped due to
setting the client_cap?
And also why calling igt_display_reset_outputs() is fixing this issue?
> Fixes: dc2d7fb4f978 ("lib/igt_kms: move setting DRM_CLIENT_CAP_WRITEBACK_CONNECTORS to kms_writeback")
> Signed-off-by: Alex Hung <alex.hung at amd.com>
> ---
> tests/kms_writeback.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
> index f89b2d62f..4c54f3b89 100644
> --- a/tests/kms_writeback.c
> +++ b/tests/kms_writeback.c
> @@ -572,9 +572,11 @@ igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)
> igt_require(display.is_atomic);
>
> ret = drmSetClientCap(display.drm_fd, DRM_CLIENT_CAP_WRITEBACK_CONNECTORS, 1);
> -
Is this part needed for this patch?
> igt_require_f(!ret, "error setting DRM_CLIENT_CAP_WRITEBACK_CONNECTORS\n");
>
> + /* Refresh the outputs to grab all supported connectors.*/
> + igt_display_reset_outputs(&display);
> +
> output = kms_writeback_get_output(&display);
> igt_require(output);
>
More information about the igt-dev
mailing list