[PATCH 3/4] lib/gpgpu_shader: add inline support for iga64 assembly

[Andrzej Hajda]

Thanks for looking at the patches.

On 10.05.2024 12:42, Zbigniew Kempczyński wrote:
> On Mon, Apr 29, 2024 at 02:08:19PM +0200, Andrzej Hajda wrote:
> <cut>
>
>> +# check if we need to recompile - checksum difference and compiler present
>> +MD5_ASMS="$(for a in "${ASMS[@]}"; do echo "${a#*:}"; done | md5sum|cut -b1-32)"
> Why not use:
> MD5_ASMS=$(echo "${ASMS[@]}" | md5sum | cut -b1-32)
>
> I'm not sure but your check doesn't support function (asm) rename.

My version deliberately skips asm names because they are not passed to 
the compiler, so the output
of iga64 does not depend on it. But you are right, after name change 
output file should be regenerated.
Will be fixed.

Regards
Andrzej
> --
> Zbigniew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20240514/f8f0caa4/attachment.htm>