[PATCH i-g-t v2 00/10] helper function

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed May 15 17:29:14 UTC 2024


Hi Bommu,
On 2024-05-14 at 12:40:16 +0530, Bommu Krishnaiah wrote:
> Introduce helper functions for object creation, binding, submission,
> and destruction, applicable for SVM and other tests
> 
> xe-basic test is validating the helper function introduced in 'lib/xe/xe_util: helper function'
> 
> svm test cases:
> svm-basic-malloc
> svm-basic-mmap
> svm-random-access
> svm-huge-page
> svm-atomic-access
> svm-atomic-access
> svm_invalid_va
---- ^
No underscores in tests names.

> svm-mprotect
> svm-benchmark
> svm-sparse-access
> 
> svm kernel implimentation:
> https://gitlab.freedesktop.org/oak/xe-kernel-driver-svm.git
> branch: origin/drm-xe-next-svm-unify-userptr
> 

Please improve and then resend with another subject, 'helper function'
is misleading. What about 'Add tests for Shared Virtual Memory (SVM)'?

> 
> Bommu Krishnaiah (10):
>   lib/xe/xe_util: Introduce helper functions for buffer creation and
>     command submission etc
>   tests/intel/xe_svm: basic xe_svm test
>   tests/xe_svm: basic svm test
>   tests/intel/xe_svm: svm_random_access
-------------------------- ^
svm-random-access

>   tests/intel/xe_svm: svm-huge-page
>   tests/intel/xe_svm: svm_atomic_access
-------------------------- ^
svm-atomic-access

>   tests/intel/xe_svm: svm-invalid-va
>   tests/intel/xe_svm: svm_benchmark

svm-benchmark

>   tests/intel/xe_svm: svm_mprotect

svm-mprotect

>   tests/intel/xe_svm: svm-sparse-access

Regards,
Kamil

> 
>  include/drm-uapi/xe_drm.h |   2 +
>  lib/xe/xe_util.c          | 186 +++++++++++++++++
>  lib/xe/xe_util.h          |  40 ++++
>  tests/intel/xe_svm.c      | 427 ++++++++++++++++++++++++++++++++++++++
>  tests/meson.build         |   1 +
>  5 files changed, 656 insertions(+)
>  create mode 100644 tests/intel/xe_svm.c
> 
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list