[PATCH i-g-t] lib/igt_fb: Mark Xe framebuffers as slow access

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Tue May 28 07:47:34 UTC 2024


On Mon, May 27, 2024 at 04:17:47PM +0300, Juha-Pekka Heikkila wrote:
> Reading from Xe device framebuffers is slow hence mark is as such.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> ---
>  lib/igt_fb.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 5df5cb08f..26d6957f8 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -4401,7 +4401,8 @@ static void create_cairo_surface__convert(int fd, struct igt_fb *fb)
>  		setup_linear_mapping(&blit->base);
>  
>  		/* speed things up by working from a copy in system memory */
> -		cvt.src.slow_reads = is_i915_device(fd) && !gem_has_mappable_ggtt(fd);
> +		cvt.src.slow_reads = (is_i915_device(fd) && !gem_has_mappable_ggtt(fd)) ||
> +			is_xe_device(fd);
>  	} else {
>  		blit->base.linear.fb = *fb;
>  		blit->base.linear.fb.gem_handle = 0;
> @@ -4409,7 +4410,7 @@ static void create_cairo_surface__convert(int fd, struct igt_fb *fb)
>  		igt_assert(blit->base.linear.map);
>  
>  		/* reading via gtt mmap is slow */
> -		cvt.src.slow_reads = is_i915_device(fd);
> +		cvt.src.slow_reads = is_intel_device(fd);
>  	}
>  
>  	cvt.dst.ptr = blit->shadow_ptr;
> -- 
> 2.43.2
> 

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew


More information about the igt-dev mailing list