[PATCH i-g-t 1/2] lib/igt_chamelium: check drmModeGetConnector() return value in wait_for_connected_state()

[Luca Coelho]

On Mon, 2024-05-27 at 16:18 +0200, Kamil Konieczny wrote:
> Hi Luca,
> On 2024-05-23 at 11:44:25 +0300, Luca Coelho wrote:
> > The drmModeGetConnector() function can return NULL in some cases, so
> > we need to check the return value before accessing it.  This is not
> > being checked in wait_for_connected_state(), so fix that.
> > 
> > Signed-off-by: Luca Coelho <luciano.coelho at intel.com>
> > ---
> >  lib/igt_chamelium.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
> > index 016d5356630c..b1478654d02a 100644
> > --- a/lib/igt_chamelium.c
> > +++ b/lib/igt_chamelium.c
> > @@ -524,6 +524,9 @@ static bool wait_for_connected_state(int drm_fd,
> >  			drmModeConnector *connector =
> >  				drmModeGetConnector(drm_fd, connectors[i]);
> >  
> > +			if (!connector)
> > +				break;
> > +
> 
> You could have first connector connected, second not connected,
> so this should be:
> 			if (!connector) {
>                 connected = false;
> 			    break;
>             }

Yes, you're right! Nice catch.  I'll change this.

--
Cheers,
Luca.