[PATCH i-g-t 1/5] tests/fbdev: Fix fd closure
Kamil Konieczny
kamil.konieczny at linux.intel.com
Tue May 28 15:26:28 UTC 2024
Hi Bhanuprakash,
On 2024-05-28 at 11:12:19 +0530, Bhanuprakash Modem wrote:
> As the file descriptor in this test is not a drm device,
> don't use drm_close_driver() to close the fd, instead
> use close().
>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
Please add me also to Cc in cover letter, I could overlook
your patchseries otherwise.
> ---
> tests/fbdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/fbdev.c b/tests/fbdev.c
> index 154e78b0f..794882a6a 100644
> --- a/tests/fbdev.c
> +++ b/tests/fbdev.c
> @@ -443,6 +443,6 @@ igt_main
> }
>
> igt_fixture {
> - drm_close_driver(fd);
> + close(fd);
LGTM,
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> }
> }
> --
> 2.43.2
>
More information about the igt-dev
mailing list