[PATCH i-g-t 1/2] lib/igt_chamelium: check drmModeGetConnector() return value in wait_for_connected_state()

Luca Coelho luca at coelho.fi
Wed May 29 21:35:48 UTC 2024


On Wed, 2024-05-29 at 19:16 +0200, Kamil Konieczny wrote:
> Hi Luca,
> On 2024-05-28 at 10:20:45 +0300, Luca Coelho wrote:
> > On Fri, 2024-05-24 at 18:58 +0200, Kamil Konieczny wrote:
> > > Hi Luca,
> > 
> > Hi Kamil,
> > 
> > 
> > > On 2024-05-23 at 11:44:25 +0300, Luca Coelho wrote:
> > > 
> > > I have two nits, one about too long subject:
> > > 
> > > [PATCH i-g-t 1/2] lib/igt_chamelium: check drmModeGetConnector() return value in wait_for_connected_state()
> > 
> > Yes, it's a bit too long, but I wanted to convey useful information in
> > the subject...
> > 
> > 
> > > imho better:
> > > 
> > > [PATCH i-g-t 1/2] lib/igt_chamelium: avoid NULL dereference in wait_for_connected_state()
> > 
> > Okay, this is descriptive enough, but loses the context of the problem
> > with drmModeGetConnector(), which I'm addressing in this series.
> > 
> > 
> > > or even shorter:
> > > 
> > > [PATCH i-g-t 1/2] lib/igt_chamelium: fix wait_for_connected_state()
> > 
> > IMHO this is way too generic.
> > 
> > What about this?
> > 
> > [PATCH i-g-t 1/2] lib/igt_chamelium: check drmModeGetConnector() return in wait_for_connected_state()
> 
> imho still too long, another idea:
> 
> lib/igt_chamelium: check drmModeGetConnector() before using

Yeah, thanks, I think this is usable.  I'll change it.  Sorry, I just
saw this reply now, well after I had resubmitted my patches.

--
Cheers,
Luca.


More information about the igt-dev mailing list