[PATCH i-g-t 08/20] tools/intel_vbt_decode: Decode the "not HDMI" bit right way up

Ville Syrjala ville.syrjala at linux.intel.com
Fri May 31 14:23:42 UTC 2024


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

The inverted decoding of the "not HDMI" bit is confusing me more
than it's helping as it typically gets flagged for all non-HDMI/DVI
encoders now. Just decode it the same way the VBT specifies
it.

The other option would be to only do the invert trick when TMDS
encoding is supported. But dunno how confusing that would be.

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 tools/intel_vbt_decode.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
index f01f90b301f7..6cf6d471b5e2 100644
--- a/tools/intel_vbt_decode.c
+++ b/tools/intel_vbt_decode.c
@@ -775,7 +775,7 @@ static const struct {
 	{ DEVICE_TYPE_POWER_MANAGEMENT, "Power management" },
 	{ DEVICE_TYPE_HOTPLUG_SIGNALING, "Hotplug signaling" },
 	{ DEVICE_TYPE_INTERNAL_CONNECTOR, "Internal connector" },
-	{ DEVICE_TYPE_NOT_HDMI_OUTPUT, "HDMI output" }, /* decoded as inverse */
+	{ DEVICE_TYPE_NOT_HDMI_OUTPUT, "Not HDMI output" },
 	{ DEVICE_TYPE_MIPI_OUTPUT, "MIPI output" },
 	{ DEVICE_TYPE_COMPOSITE_OUTPUT, "Composite output" },
 	{ DEVICE_TYPE_DUAL_CHANNEL, "Dual channel" },
@@ -793,8 +793,6 @@ static void dump_child_device_type_bits(uint16_t type)
 {
 	int i;
 
-	type ^= DEVICE_TYPE_NOT_HDMI_OUTPUT;
-
 	for (i = 0; i < ARRAY_SIZE(child_device_type_bits); i++) {
 		if (child_device_type_bits[i].mask & type)
 			printf("\t\t\t%s\n", child_device_type_bits[i].name);
-- 
2.44.1



More information about the igt-dev mailing list