[PATCH i-g-t] tests/kms_vrr: data->switch modes[LOW_RR_MODE] not initialized for lobf test

B, Jeevan jeevan.b at intel.com
Mon Nov 4 09:07:34 UTC 2024


LGTM

Reviewed-by: Jeevan B <jeevan.b at intel.com>

> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander at intel.com>
> Sent: Thursday, October 31, 2024 5:44 PM
> To: igt-dev at lists.freedesktop.org
> Cc: B, Jeevan <jeevan.b at intel.com>; Hogander, Jouni
> <jouni.hogander at intel.com>
> Subject: [PATCH i-g-t] tests/kms_vrr: data->switch modes[LOW_RR_MODE]
> not initialized for lobf test
> 
> lobf subtest is using data->switch_modes[LOW_RR_MODE] but not initializing
> it. Fix this in output_constraint.
> 
> Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
> ---
>  tests/kms_vrr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c index 36a22eebe..d0db954fa
> 100644
> --- a/tests/kms_vrr.c
> +++ b/tests/kms_vrr.c
> @@ -923,7 +923,7 @@ static bool output_constraint(data_t *data,
> igt_output_t *output, uint32_t flags
>  	igt_output_override_mode(output, &data-
> >switch_modes[HIGH_RR_MODE]);
> 
>  	/* Search for a low refresh rate mode. */
> -	if (!(flags & (TEST_SEAMLESS_VRR | TEST_SEAMLESS_DRRS)))
> +	if (!(flags & (TEST_SEAMLESS_VRR | TEST_SEAMLESS_DRRS |
> +TEST_LINK_OFF)))
>  		return true;
> 
>  	data->switch_modes[LOW_RR_MODE] =
> low_rr_mode_with_same_res(output, data->range.min);
> --
> 2.34.1



More information about the igt-dev mailing list