[PATCH i-g-t 2/3] lib/igt_kmod: Stop handling _kunit suffix

[Janusz Krzysztofik]

Hi Lucas,

On Tuesday, 5 November 2024 06:52:54 CET Lucas De Marchi wrote:
> It's not used anywhere anymore. Remove it.

I'm not sure.  I added this option based on KUnit documentation.  Has the 
documentation changed since then?  I haven't been watching it.  Have you 
checked if core drm doesn't use that suffix?   If it is still documented then 
what if we decide to run kunit tests from other subsytems (dma-buf? iommu?) 
and it occurs they still use it?

Thanks,
Janusz

> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  lib/igt_kmod.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index 4eeab79ec..58edac8fa 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -1189,7 +1189,7 @@ static void __igt_kunit(struct igt_ktest *tst,
>   *	   if NULL then test cases from all test suites provided by the module
>   *	   are executed as dynamic sub-subtests of one IGT subtest, which name
>   *	   is derived from the module name by cutting off its optional trailing
> - *	   _test or _kunit suffix
> + *	   _test suffix
>   * @opts: options to load the module
>   *
>   * Loads the test module, parses its (k)tap dmesg output, then unloads it
> @@ -1213,9 +1213,6 @@ void igt_kunit(const char *module_name, const char *suite, const char *opts)
>  		if (!igt_debug_on(!subtest)) {
>  			char *suffix = strstr(subtest, "_test");
>  
> -			if (!suffix)
> -				suffix = strstr(subtest, "_kunit");
> -
>  			if (suffix)
>  				*suffix = '\0';
>  		}
>