[PATCH i-g-t v6 1/2] tests/chamelium/kms_chamelium_edid: Use extended flag to reduce the number of edid

[Kamil Konieczny]

Hi Pranay,
On 2024-11-05 at 21:40:25 +0530, Pranay Samala wrote:
> This test iterates on all the available edids of HDMI.
> Due to CI test timeut limitation, we are reducing the
> number of edids to execute to avoid result as timeout.
> 
> Using extended flag to achieve this. The test will execute
> only 25 edids when this flag is not used as CI doesnt uses
> this flag.
> In local execution to execute on all edids, we have to give
> this flag at the runtime.
> 
> Edid of 1920x1200 59.950 Hz mode is a redundant edid, shuffling
> it with edid of 2560x1600 59.972 Hz mode to have all edid's coverage.

Please do not mix this, rather send it in separate patch,
also add to Cc devs found from 'git blame', here +cc Mark

Cc: Mark Yacoub <markyacoub at chromium.org>
Cc: Mark Yacoub <markyacoub at google.com>
> Signed-off-by: Pranay Samala <pranay.samala at intel.com>

Regards,
Kamil

> ---
>  lib/monitor_edids/hdmi_edids.h       | 52 ++++++++++++++--------------
>  tests/chamelium/kms_chamelium_edid.c | 28 ++++++++++++++-
>  2 files changed, 53 insertions(+), 27 deletions(-)
> 
> diff --git a/lib/monitor_edids/hdmi_edids.h b/lib/monitor_edids/hdmi_edids.h
> index 9d75cfa98..f6cfe82ff 100644
> --- a/lib/monitor_edids/hdmi_edids.h
> +++ b/lib/monitor_edids/hdmi_edids.h
> @@ -250,23 +250,15 @@ monitor_edid HDMI_EDIDS_NON_4K[] = {
>  		  "34353732323059575320000000fc0044"
>  		  "454c4c20323430375746500a000000fd"
>  		  "00384c1e5311000a2020202020200068" },
> -	{ .name = "DEL_61462_DELL_U2410_HDMI",
> -	  .edid = "00ffffffffffff0010ac16f04c4e4332"
> -		  "1f13010380342078ea1ec5ae4f34b126"
> -		  "0e5054a54b008180a940d100714f0101"
> -		  "010101010101283c80a070b023403020"
> -		  "360006442100001a000000ff00463532"
> -		  "354d39375332434e4c0a000000fc0044"
> -		  "454c4c2055323431300a2020000000fd"
> -		  "00384c1e5111000a202020202020012e"
> -		  "020329f15090050403020716011f1213"
> -		  "14201511062309070767030c00100038"
> -		  "2d83010000e3050301023a801871382d"
> -		  "40582c450006442100001e011d801871"
> -		  "1c1620582c250006442100009e011d00"
> -		  "7251d01e206e28550006442100001e8c"
> -		  "0ad08a20e02d10103e96000644210000"
> -		  "1800000000000000000000000000003e" },
> +	{ .name = "HWP_12442_HP_Z30i_HDMI",
> +	  .edid = "00ffffffffffff0022f09a3001010101"
> +		  "06180103804028782a1df5ae4f35b325"
> +		  "0d5054a10800d100b30095008100a940"
> +		  "8180d1c081c0e26800a0a0402e603020"
> +		  "360081902100001a000000fd00324618"
> +		  "621b000a202020202020000000fc0048"
> +		  "50205a3330690a2020202020000000ff"
> +		  "00434e34343036304742530a20200078" },
>  	{ .name = "DTV_0_DTV_HDMI",
>  	  .edid = "00ffffffffffff001296000001010101"
>  		  "0c180103803a20780a0dc9a057479827"
> @@ -507,15 +499,23 @@ monitor_edid HDMI_EDIDS_NON_4K[] = {
>  		  "442100001e011d00bc52d01e20b82855"
>  		  "4006442100001e8c0ad08a20e02d1010"
>  		  "3e9600064421000018000000000000c1" },
> -	{ .name = "HWP_12442_HP_Z30i_HDMI",
> -	  .edid = "00ffffffffffff0022f09a3001010101"
> -		  "06180103804028782a1df5ae4f35b325"
> -		  "0d5054a10800d100b30095008100a940"
> -		  "8180d1c081c0e26800a0a0402e603020"
> -		  "360081902100001a000000fd00324618"
> -		  "621b000a202020202020000000fc0048"
> -		  "50205a3330690a2020202020000000ff"
> -		  "00434e34343036304742530a20200078" },
> +	{ .name = "DEL_61462_DELL_U2410_HDMI",
> +	  .edid = "00ffffffffffff0010ac16f04c4e4332"
> +		  "1f13010380342078ea1ec5ae4f34b126"
> +		  "0e5054a54b008180a940d100714f0101"
> +		  "010101010101283c80a070b023403020"
> +		  "360006442100001a000000ff00463532"
> +		  "354d39375332434e4c0a000000fc0044"
> +		  "454c4c2055323431300a2020000000fd"
> +		  "00384c1e5111000a202020202020012e"
> +		  "020329f15090050403020716011f1213"
> +		  "14201511062309070767030c00100038"
> +		  "2d83010000e3050301023a801871382d"
> +		  "40582c450006442100001e011d801871"
> +		  "1c1620582c250006442100009e011d00"
> +		  "7251d01e206e28550006442100001e8c"
> +		  "0ad08a20e02d10103e96000644210000"
> +		  "1800000000000000000000000000003e" },
>  	{ .name = "HWP_12447_HP_Z24i_HDMI",
>  	  .edid = "00ffffffffffff0022f09f3001010101"
>  		  "1a180103803420782e3c50a7544da226"
> diff --git a/tests/chamelium/kms_chamelium_edid.c b/tests/chamelium/kms_chamelium_edid.c
> index 8438f5f15..ca1f82227 100644
> --- a/tests/chamelium/kms_chamelium_edid.c
> +++ b/tests/chamelium/kms_chamelium_edid.c
> @@ -38,6 +38,7 @@
>  #include <string.h>
>  #include <stdatomic.h>
>  #include <xf86drmMode.h>
> +#include "drmtest.h"
>  
>  #include "config.h"
>  #include "igt.h"
> @@ -121,7 +122,9 @@
>   * @suspend:      suspend
>   */
>  
> +#define CI_LIMIT 25
>  #define MODE_CLOCK_ACCURACY 0.05 /* 5% */
> +static bool extended;
>  
>  static void get_connectors_link_status_failed(chamelium_data_t *data,
>  					      bool *link_status_failed)
> @@ -269,9 +272,18 @@ static void edid_stress_resolution(chamelium_data_t *data,
>  	int i;
>  	struct chamelium *chamelium = data->chamelium;
>  	struct udev_monitor *mon = igt_watch_uevents();
> +	enum intel_driver driver = get_intel_driver(data->drm_fd);
> +
>  	chamelium_reset_state(&data->display, data->chamelium, port,
>  			      data->ports, data->port_count);
>  
> +	if (!extended && (driver == INTEL_DRIVER_XE || driver == INTEL_DRIVER_I915) &&
> +	    is_intel_device(data->drm_fd))
> +		edids_list_len = CI_LIMIT;
> +
> +	/* TODO: Make changes to check if we can get rid of extended flag and explore
> +	 * if there is environment variable in CI when executing with igt_runner
> +	 */
>  
>  	for (i = 0; i < edids_list_len; ++i) {
>  		struct chamelium_edid *chamelium_edid;
> @@ -504,8 +516,22 @@ static void test_mode_timings(chamelium_data_t *data,
>  	} while (++i < count_modes);
>  }
>  
> +static int opt_handler(int opt, int opt_index, void *_data)
> +{
> +	switch (opt) {
> +	case 'e':
> +		extended = true;
> +		break;
> +	}
> +
> +	return IGT_OPT_HANDLER_SUCCESS;
> +}
> +
> +const char *help_str =
> +	"  -e \tExtended tests.\n";
> +
>  IGT_TEST_DESCRIPTION("Testing EDID with a Chamelium board");
> -igt_main
> +igt_main_args("e", NULL, help_str, opt_handler, NULL)
>  {
>  	chamelium_data_t data;
>  	struct chamelium_port *port;
> -- 
> 2.34.1
>