[PATCH] tests/xe_spin_batch: Add spin-timestamp-check

Lucas De Marchi lucas.demarchi at intel.com
Thu Nov 7 14:45:47 UTC 2024


On Thu, Nov 07, 2024 at 08:35:45AM +0100, Zbigniew Kempczyński wrote:
>On Wed, Nov 06, 2024 at 11:08:20AM -0600, Lucas De Marchi wrote:
>
><cut>
>> > +/**
>> > + * SUBTEST: spin-timestamp-check
>> > + * Description: Intiate gt reset then check the timestamp register for each engine.
>> > + * Test category: functionality test
>> > + */
>> > +static void xe_spin_timestamp_check(int fd, struct drm_xe_engine_class_instance *eci)
>> > +{
>> > +
>> > +	exec_store(fd, eci, false);
>>
>> what is the first exec for?
>
>That's sanity check exec submission is working fine before we submit job
>which will hang it. If you think it is not necessary it might be dropped.
>I'm not sure if is possible situation so that check might point if test
>prerequisites are not met (and on CI we just die on exec). But then I
>think fence error code should be checked as well.

a debug message before it would be great so we know when it failed (as a
prereq or as the real execution). Or at the least a comment on top.

Lucas De Marchi


More information about the igt-dev mailing list