[PATCH i-g-t v2] igt-runner fact checking

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu Nov 7 17:44:19 UTC 2024


Hi Peter,
On 2024-11-07 at 08:03:12 +0100, Peter Senna Tschudin wrote:
> Hi Kamil,
> 
> Thank you for your review. Please see my comment below:
> 
> [...]
> 
> >> diff --git a/lib/igt_facts.h b/lib/igt_facts.h
> >> new file mode 100644
> >> index 000000000..b649f93b3
> >> --- /dev/null
> >> +++ b/lib/igt_facts.h
> >> @@ -0,0 +1,55 @@
> >> +// SPDX-License-Identifier: MIT
> > 
> > In headers use /* SPDX-.... */
> 
> Checkpatch can't decide itself. No matter the format, it complains...
> 
> WARNING: Improper SPDX comment style for 'lib/igt_facts.c', please use '//' instead
> #70: FILE: lib/igt_facts.c:1:
> +/* SPDX-License-Identifier: MIT */
> 
> [...]

Headers .h and C source .c have different convention.

Regards,
Kamil



More information about the igt-dev mailing list