[PATCH v2] lib: sync PCI ID macros with kernel

Lucas De Marchi lucas.demarchi at intel.com
Fri Nov 8 15:46:28 UTC 2024


On Fri, Nov 08, 2024 at 12:20:44PM +0200, Jani Nikula wrote:
>On Thu, 07 Nov 2024, Ngai-Mint Kwan <ngai-mint.kwan at linux.intel.com> wrote:
>> diff --git a/lib/i915/perf.c b/lib/i915/perf.c
>> index ef2f74be8..9eb1141d4 100644
>> --- a/lib/i915/perf.c
>> +++ b/lib/i915/perf.c
>> @@ -37,7 +37,7 @@
>>
>>  #include <i915_drm.h>
>>
>> -#include "i915_pciids.h"
>> +#include "pciids.h"
>>  #include "i915_pciids_local.h"
>
>After this gets merged, maybe you could write a follow-up patch that
>renames i915_pciids_local.h to pciids_local.h and cleans it up; there's

Actually to remove it. Why are we still carrying that?
Or maybe keep it just for the IDs from the topic branch (which we won't
add more to, hopefully) so we can keep sync'ing with drm-xe, or
drm-intel or drm-next, depending on the context.

Lucas De Marchi

>some old cruft in there.
>
>
>BR,
>Jani.
>
>
>-- 
>Jani Nikula, Intel


More information about the igt-dev mailing list