[PATCH i-g-t v7] tests/kms_3d: Add more logs to skips/failure

Pranay Samala pranay.samala at intel.com
Thu Nov 14 03:17:53 UTC 2024


Having some logs for test failures and skips would
make debugging much easier.

v2: Remove CRTC log for fail/skip (Bhanu)

v3: Add check for connector connection

v4: Remove check for connector connection (Bhanu)

v5: Rebasing and sending other version

v6: Remove igt_info for connector support (Bhanu)

v7: Add Reviewed by statement in commit message (Swati)

Signed-off-by: Pranay Samala <pranay.samala at intel.com>

Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
---
 tests/kms_3d.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/kms_3d.c b/tests/kms_3d.c
index ad6c45e9b..8e9e9929c 100644
--- a/tests/kms_3d.c
+++ b/tests/kms_3d.c
@@ -55,7 +55,8 @@ igt_simple_main
 	res = drmModeGetResources(drm_fd);
 	igt_require(res);
 
-	igt_assert(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_STEREO_3D, 1) >= 0);
+	igt_assert_f(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_STEREO_3D, 1) >= 0,
+		     "Failed to enable STEREO_3D capability.\n");
 
 	/* find an hdmi connector */
 	for (int i = 0; i < res->count_connectors; i++) {
@@ -65,7 +66,7 @@ igt_simple_main
 		drmModeFreeConnector(connector);
 		connector = NULL;
 	}
-	igt_require(connector);
+	igt_require_f(connector, "No HDMI connector found.\n");
 
 	kmstest_unset_all_crtcs(drm_fd, res);
 
@@ -85,7 +86,7 @@ igt_simple_main
 			mode_count++;
 	}
 
-	igt_assert(mode_count);
+	igt_assert_f(mode_count, "3D modes not detected.\n");
 
 	/* set 3D modes */
 	igt_info("Testing:\n");
-- 
2.34.1



More information about the igt-dev mailing list