[PATCH i-g-t v1] tests/kms_hdr: Skip brightness on non-internal panels

Samala, Pranay pranay.samala at intel.com
Thu Nov 14 06:10:49 UTC 2024



> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Santhosh
> Reddy Guddati
> Sent: Wednesday, November 13, 2024 7:56 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Sharma, Swati2 <swati2.sharma at intel.com>; Reddy Guddati, Santhosh
> <santhosh.reddy.guddati at intel.com>
> Subject: [PATCH i-g-t v1] tests/kms_hdr: Skip brightness on non-internal panels
> 
> Skip the brightness test if the output is not an internal panel and log the skip
> message.
> 
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
Code LGTM. 
Get the CI results green.

Reviewed-by: Pranay Samala <pranay.samala at intel.com>
> ---
>  tests/kms_hdr.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c index b67902d43..c4c9df3fc
> 100644
> --- a/tests/kms_hdr.c
> +++ b/tests/kms_hdr.c
> @@ -696,6 +696,12 @@ static void test_hdr(data_t *data, uint32_t flags)
>  			continue;
>  		}
> 
> +		if ((flags & TEST_BRIGHTNESS) &&
> !output_is_internal_panel(output)) {
> +			igt_info("%s: Can't run brightness test on non-internal
> panel.\n",
> +				 igt_output_name(output));
> +			continue;
> +		}
> +
>  		for_each_pipe(display, pipe) {
>  			igt_output_set_pipe(output, pipe);
>  			if (!intel_pipe_output_combo_valid(display)) {
> --
> 2.34.1



More information about the igt-dev mailing list