[PATCH i-g-t v3 1/2] tests/kms_flip: Update the skip message

Sharma, Swati2 swati2.sharma at intel.com
Thu Nov 14 06:32:45 UTC 2024


LGTM

Reviewed-by: Swati Sharma <swati2.sharma at intel.com>

On 14-11-2024 10:48 am, Pranay Samala wrote:
> Debugging would be easier if we had logs available for
> test failures and skips. This patch rephrases the skip
> message for better understanding.
>
> v2:
> - Remove .c extension in the filename (Swati)
>
> v3:
> - Add changes made in previous version in commit message (Swati)
> - Editing hax patch
>
> Signed-off-by: Pranay Samala <pranay.samala at intel.com>
> Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
> ---
>   tests/kms_flip.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index cbabbe74f..88cd41083 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1896,7 +1896,7 @@ static void run_pair(int duration, int flags)
>   
>   	/* If we have fewer than 2 connected outputs then we won't have any
>   	 * configuration at all. So skip in that case. */
> -	igt_require_f(modes, "At least two displays required\n");
> +	igt_require_f(modes, "At least two displays with same modes are required\n");
>   
>   	if (duration) {
>   		duration = duration * 1000 / modes;


More information about the igt-dev mailing list