[PATCH i-g-t] tests/kms_color: fix data->output

Modem, Bhanuprakash bhanuprakash.modem at intel.com
Thu Nov 14 08:20:21 UTC 2024


On 12-11-2024 06:26 pm, Swati Sharma wrote:
> data->output at dynamic subtest is getting overwritten by some
> other output.
> 
> For ex:
>      Starting dynamic subtest: pipe-C-eDP-1
>      pipe-C-DP-1: (Max dot-clock: 1305600 KHz), force joiner: No
> 	7680x4320: 30 1030250 7680 7710 7720 7880 4320 4323 4328 4368 0x48 0x9
>      pipe-C: Last pipe couldn't be used as a Bigjoiner Primary.
>      Test requirement not met in function run_ctm_tests_for_pipe, file
>      ../tests/kms_color.c:827:
>      Test requirement: pipe_output_combo_valid(data, p)
>      Last errno: 2, No such file or directory
>      Dynamic subtest pipe-C-eDP-1: SKIP (0.001s)
> 
> Here, eDP-1 at dynamic subtest is getting overwritten by DP-1
> leading to false results.
> 
> Fixes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3362
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>

LGTM
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>

> ---
>   tests/kms_color.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_color.c b/tests/kms_color.c
> index d642f561d..4b71d3dd3 100644
> --- a/tests/kms_color.c
> +++ b/tests/kms_color.c
> @@ -760,10 +760,6 @@ static void test_setup(data_t *data, enum pipe p)
>   					  data->primary->pipe->pipe,
>   					  IGT_PIPE_CRC_SOURCE_AUTO);
>   
> -	igt_display_require_output_on_pipe(&data->display, p);
> -	data->output = igt_get_single_output_for_pipe(&data->display, p);
> -	igt_require(data->output);
> -
>   	igt_display_reset(&data->display);
>   }
>   



More information about the igt-dev mailing list