[PATCH 1/2] scripts/generate_iga64_codes: add iga64_macros.h to checksum calculation

[Zbigniew Kempczyński]

On Thu, Nov 14, 2024 at 11:31:38AM +0100, Andrzej Hajda wrote:
> Since generated code depends on iga64_macros.h assemblies should be
> recompiled on it's change as well.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda at intel.com>
> ---
>  lib/iga64_generated_codes.c  | 2 +-
>  lib/meson.build              | 1 +
>  scripts/generate_iga64_codes | 2 +-
>  3 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/iga64_generated_codes.c b/lib/iga64_generated_codes.c
> index 6638be07b356..0bd92b8c4dc9 100644
> --- a/lib/iga64_generated_codes.c
> +++ b/lib/iga64_generated_codes.c
> @@ -3,7 +3,7 @@
>  
>  #include "gpgpu_shader.h"
>  
> -#define MD5_SUM_IGA64_ASMS ec9d477415eebb7d6983395f1bcde78f
> +#define MD5_SUM_IGA64_ASMS e2d97ef45d5f322200793a0aa76872d7
>  
>  struct iga64_template const iga64_code_gpgpu_fill[] = {
>  	{ .gen_ver = 2000, .size = 44, .code = (const uint32_t []) {
> diff --git a/lib/meson.build b/lib/meson.build
> index c3556a921adf..cec148388b77 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -248,6 +248,7 @@ iga64_generated_codes = custom_target(
>      'iga64_generated_codes.c',
>      input : [ 'iga64_generated_codes.c' ] + iga64_assembly_libs,
>      output : 'iga64_generated_codes.c',
> +    depend_files : 'iga64_macros.h',
>      command : [ generate_iga64_codes, '-o', '@OUTPUT@', '-i', '@INPUT@' ]
>  )
>  
> diff --git a/scripts/generate_iga64_codes b/scripts/generate_iga64_codes
> index bbf1f7008242..652bf01a080c 100755
> --- a/scripts/generate_iga64_codes
> +++ b/scripts/generate_iga64_codes
> @@ -40,7 +40,7 @@ while  read -d $'\0' asm; do
>  done < <(for f in $LIBS; do objcopy --dump-section .iga64_assembly=/dev/stdout $f.p/*.o /dev/null; done)
>  
>  # check if we need to recompile - checksum difference and compiler present
> -MD5_ASMS="$(md5sum <<< "${ASMS[@]}" | cut -b1-32)"
> +MD5_ASMS="$(md5sum <<< "$(< ../lib/iga64_macros.h) ${ASMS[@]}" | cut -b1-32)"
>  MD5_PRE="$(grep -Po '(?<=^#define MD5_SUM_IGA64_ASMS )\S{32,32}' $INPUT 2>/dev/null)"
>  
>  if [ "$MD5_ASMS" = "$MD5_PRE" ]; then
> 
> -- 
> 2.34.1
> 

LGTM but I've some nit - please add some comment to igt64_macros.h
in which you inform the person who's changing the header that after
rebuilding lib/iga64_generated_codes.c must be added to commit to
avoid MD5 sum mismatch.

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew