[PATCH i-g-t RESEND v3 0/2] tests/kms_properties: rework immutability checks

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Fri Nov 15 21:18:57 UTC 2024


Following the discussion on IRC, it is actually an error to require that
properties that can not be chaged are marked as immutable.

The DRM_MODE_PROP_IMMUTABLE defines more of the 'direction' of the
property (whether it is set by the kernel or it is expected to be set by
the userspace) rather than simply states that there is no way for the
userspace to change the property.

Drop the existing immutability test and spawn (as an RFC) new sanity
checker for properties.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>

---
Changes in v3:
- Split implementation into two patches, one to remove the immutability
  check and another one to add sanity checks.
- Link to v2: https://lore.kernel.org/r/20241018120058.42240-1-dmitry.baryshkov@linaro.org

Changes in v2:
- Moved GAMMA_LUT_SIZE and DEGAMMA_LUT_SIZE to DRM_MODE_OBJECT_CRTC.
- Added debug print to help debugging possible issues.
- Link to v1: https://lore.kernel.org/r/20240902210755.480638-1-dmitry.baryshkov@linaro.org

---
Dmitry Baryshkov (2):
      tests/kms_properties: drop immutability checks
      tests/kms_properties: add sanity checks for properties

 tests/kms_properties.c | 110 ++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 87 insertions(+), 23 deletions(-)
---
base-commit: 31475ea8fdeef38b5ae6b4b8ca6d4e42f8285b42
change-id: 20241027-rework-imm-check-f241ebae71a6

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov at linaro.org>



More information about the igt-dev mailing list