[PATCH i-g-t 0/3] Improvements for xe_sriov_flr test and xe_mmio lib

Marcin Bernatowicz marcin.bernatowicz at linux.intel.com
Tue Nov 19 15:55:35 UTC 2024


Enhance code maintainability, improve error handling, and provide clearer
debugging information.

lib/xe/xe_mmio: Replace open-coded init/cleanup with existing functions

Use intel_register_access_init and intel_register_access_fini to handle
initialization and cleanup, reducing code duplication. This improves
maintainability and ensures consistency, including handling forcewake
for Xe.

lib/xe/xe_sriov_provisioning: Refactor range handling and logging

Introduce an append_range helper to reduce code duplication in handling
provisioned PTE ranges. Limit debug logs to the first 70 entries for
clarity and improved reasoning. Enhance error handling by propagating
realloc failures.

tests/xe/xe_sriov_flr: Improve clear-ggtt subcheck initialization

Mark the ggtt-clear subcheck as SKIP when prerequisites, such as scanning
GGTT provisioned offsets, are not met. Asserting in these cases falsely
implies that FLR is broken, while the test has not even started.

Marcin Bernatowicz (3):
  lib/xe/xe_mmio: Replace open-coded init/cleanup with existing
    functions
  lib/xe/xe_sriov_provisioning: Refactor range handling and logging
  tests/xe/xe_sriov_flr: Improve clear-ggtt subcheck initialization

 lib/xe/xe_mmio.c               | 10 +----
 lib/xe/xe_sriov_provisioning.c | 71 ++++++++++++++++++++++------------
 tests/intel/xe_sriov_flr.c     | 11 ++++--
 3 files changed, 57 insertions(+), 35 deletions(-)

-- 
2.31.1



More information about the igt-dev mailing list