[PATCH i-g-t v2 2/2] tests/syncobj_wait: Update invalid-wait-zero-handles test
Kamil Konieczny
kamil.konieczny at linux.intel.com
Wed Nov 20 18:46:42 UTC 2024
Hi Krzysztof,
On 2024-11-20 at 11:35:07 +0100, Krzysztof Niemiec wrote:
> The behavior of DRM_IOCTL_SYNCOBJ_TIMELINE_WAIT has been changed in [1]
> to accept empty lists of syncobj handles, but the
> invalid-wait-zero-handles test has not been updated to mirror this
> change. Fix the assert to check against 0 instead of -EINVAL, and rename
> the test to wait-zero-handles as this is no longer an invalid scenario.
>
> This change mirrors [2] for the syncobj_wait test.
>
> [1] https://patchwork.freedesktop.org/patch/554042/
> [2] https://patchwork.freedesktop.org/patch/618483/
>
> Signed-off-by: Krzysztof Niemiec <krzysztof.niemiec at intel.com>
Again you dropped my r-b here, it still holds so
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
> tests/syncobj_wait.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/syncobj_wait.c b/tests/syncobj_wait.c
> index be7e67163..e5f251205 100644
> --- a/tests/syncobj_wait.c
> +++ b/tests/syncobj_wait.c
> @@ -80,8 +80,6 @@
> *
> * SUBTEST: invalid-wait-illegal-handle
> *
> - * SUBTEST: invalid-wait-zero-handles
> - *
> * SUBTEST: multi-wait-all-for-submit-signaled
> *
> * SUBTEST: multi-wait-all-for-submit-submitted
> @@ -177,6 +175,8 @@
> * SUBTEST: wait-for-submit-delayed-submit
> *
> * SUBTEST: wait-for-submit-snapshot
> + *
> + * SUBTEST: wait-zero-handles
> */
>
> IGT_TEST_DESCRIPTION("Tests for the drm sync object wait API");
> @@ -297,7 +297,7 @@ static void
> test_wait_zero_handles(int fd)
> {
> struct drm_syncobj_wait wait = { 0 };
> - igt_assert_eq(__syncobj_wait(fd, &wait), -EINVAL);
> + igt_assert_eq(__syncobj_wait(fd, &wait), 0);
> }
>
> static void
> @@ -918,7 +918,7 @@ igt_main
> igt_subtest("invalid-wait-bad-flags")
> test_wait_bad_flags(fd);
>
> - igt_subtest("invalid-wait-zero-handles")
> + igt_subtest("wait-zero-handles")
> test_wait_zero_handles(fd);
>
> igt_subtest("invalid-wait-illegal-handle")
> --
> 2.45.2
>
More information about the igt-dev
mailing list