[PATCH i-g-t 2/3] tests/kms_async_flips: Skip Async flips on joiner output

Sharma, Swati2 swati2.sharma at intel.com
Thu Nov 21 18:07:03 UTC 2024


Hi Jeevan,

Please use latest rev of Santhosh's patch 
https://patchwork.freedesktop.org/patch/625224/?series=140349&rev=4

On 20-11-2024 11:13 pm, Jeevan B wrote:
> Async flips are disallowed with joiner, but the test commit still
> goes through and causes failures. Update the tests to skip on
> joiner outputs.
>
> Signed-off-by: Jeevan B <jeevan.b at intel.com>
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
> ---
>   tests/kms_async_flips.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index 5dec71291..486c03b32 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -653,6 +653,9 @@ static void run_test(data_t *data, void (*test)(data_t *))
>   		data->allow_fail = false;
>   		data->modifier = default_modifier(data);
>   		igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data->pipe), data->output->name) {
> +			/* TODO: Remove this workaround when Async+joiner is supported */
> +			igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
> +				      "Joiner mode found, skipping the test\n");
>   			test_init_fbs(data);
>   			test(data);
>   		}
> @@ -674,6 +677,9 @@ static void run_test_with_modifiers(data_t *data, void (*test)(data_t *))
>   			igt_dynamic_f("pipe-%s-%s-%s", kmstest_pipe_name(data->pipe),
>   				      data->output->name,
>   				      igt_fb_modifier_name(data->modifier)) {
> +				/* TODO: Remove workaround when Async+joiner is supported */
> +				igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
> +					      "Joiner mode found, skipping the test\n");
>   				test_init_fbs(data);
>   				test(data);
>   			}


More information about the igt-dev mailing list