[PATCH i-g-t 1/2] tests/intel/kms_big_fb: Intel display version 20 onwards doesn't do hflip with tile4

[B, Jeevan]

Please fix the warn. before merging

../tests/intel/kms_big_fb.c: In function ‘test_requirements’:
../tests/intel/kms_big_fb.c:969:39: warning: declaration of ‘data’ shadows a global declaration [-Wshadow]
  969 | static bool test_requirements(data_t *data, int l)
      |                               ~~~~~~~~^~~~
../tests/intel/kms_big_fb.c:928:15: note: shadowed declaration is here
  928 | static data_t data = {};
      |               ^~~~
[24/24] Generating intel-ci-tests with a custom command.

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Sharma,
> Swati2
> Sent: Friday, November 22, 2024 12:50 AM
> To: Samala, Pranay <pranay.samala at intel.com>; igt-
> dev at lists.freedesktop.org
> Cc: B S, Karthik <karthik.b.s at intel.com>; Lattannavar, Sameer
> <sameer.lattannavar at intel.com>
> Subject: Re: [PATCH i-g-t 1/2] tests/intel/kms_big_fb: Intel display version 20
> onwards doesn't do hflip with tile4
> 
> LGTM
> 
> Reviewed-by: Swati Sharma <swati2.sharma at intel.com>
> 
> On 18-11-2024 01:48 pm, Pranay Samala wrote:
> > Intel display version 20 onwards, Tile4 no longer can be used with
> > horizontal flip.
> >
> > Bspec: 69853
> >
> > Signed-off-by: Pranay Samala <pranay.samala at intel.com>
> > ---
> >   tests/intel/kms_big_fb.c | 15 +++++++++++++++
> >   1 file changed, 15 insertions(+)
> >
> > diff --git a/tests/intel/kms_big_fb.c b/tests/intel/kms_big_fb.c index
> > 7da3d12d4..ab44a9a42 100644
> > --- a/tests/intel/kms_big_fb.c
> > +++ b/tests/intel/kms_big_fb.c
> > @@ -965,6 +965,19 @@ static const struct {
> >   	{ 0, "" },
> >   	{ IGT_REFLECT_X, "-hflip" },
> >   };
> > +
> > +static bool test_requirements(data_t *data, int l) {
> > +	/* Intel display version 20 onwards cannot do reflect-x with tile4 */
> > +	if (!(!is_intel_device(data->drm_fd) ||
> > +	      intel_display_ver(intel_get_drm_devid(data->drm_fd)) < 20 ||
> > +	      !(fliptab[l].flip == IGT_REFLECT_X &&
> > +	      data->modifier == I915_FORMAT_MOD_4_TILED)))
> > +		return false;
> > +
> > +	return true;
> > +}
> > +
> >   igt_main
> >   {
> >   	igt_fixture {
> > @@ -1123,6 +1136,8 @@ igt_main
> >   					igt_describe("test async flip on
> maximum hardware supported stride length for given bpp and modifiers.");
> >   					igt_subtest_f("%s-max-hw-stride-
> %dbpp-rotate-%d%s-async-flip", modifiers[i].name,
> >   						formats[j].bpp,
> rotations[k].angle, fliptab[l].flipname) {
> > +
> 	igt_require_f(test_requirements(&data, l),
> > +								      "Can't use
> reflect-x with Tile4 on intel display
> > +version 20+\n");
> >
> 	igt_require(igt_has_drm_cap(data.drm_fd,
> DRM_CAP_ASYNC_PAGE_FLIP));
> >
> 	data.max_hw_fb_width = min(data.hw_stride / (formats[j].bpp >> 3),
> data.max_fb_width);
> >   							test_scanout(&data);