[PATCH i-g-t] tests/kms_plane:Add more logs to skips/failure

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Pranay
> Samala
> Sent: Thursday, November 21, 2024 6:12 PM
> To: igt-dev at lists.freedesktop.org
> Cc: B S, Karthik <karthik.b.s at intel.com>; Sharma, Swati2
> <swati2.sharma at intel.com>; Lattannavar, Sameer
> <sameer.lattannavar at intel.com>; Samala, Pranay <pranay.samala at intel.com>
> Subject: [PATCH i-g-t] tests/kms_plane:Add more logs to skips/failure
> 
> Having some logs for test failures and skips would make debugging much
> easier.
> 
> Signed-off-by: Pranay Samala <pranay.samala at intel.com>
> ---
>  tests/kms_plane.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c index
> 77a669dc5..383149564 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -293,8 +293,11 @@ test_plane_position_with_output(data_t *data,
>  	create_fb_for_mode(data, mode, &green, &rect, 1, &primary_fb);
>  	igt_plane_set_fb(primary, &primary_fb);
> 
> -	if (!igt_plane_has_format_mod(sprite, DRM_FORMAT_XRGB8888,
> DRM_FORMAT_MOD_LINEAR))
> +	if (!igt_plane_has_format_mod(sprite, DRM_FORMAT_XRGB8888,
> DRM_FORMAT_MOD_LINEAR)) {
> +		igt_info("plane-%d does not supports XRGB format and Linear
> modifier\n",
> +			 sprite->index);
>  		return;
> +	}
> 
>  	igt_create_color_fb(data->drm_fd,
>  			    64, 64, /* width, height */
> @@ -493,7 +496,7 @@ test_plane_panning(data_t *data, enum pipe pipe)
>  		mode_found = true;
>  		break;
>  	}
> -	igt_require(mode_found);
> +	igt_require_f(mode_found, "All connector modes are skipped due to
> low
> +memory\n");
> 
>  	if (data->flags & TEST_PANNING_TOP_LEFT)
>  		test_grab_crc(data, output, pipe, &red, data->flags, &ref_crc);
> @@ -1263,13 +1266,14 @@ static void test_planar_settings(data_t *data)
>  	 * If here is added non-intel tests below require will need to be
>  	 * changed to if(..)
>  	 */
> -	igt_require(data->display.is_atomic);
> +	igt_require_f(data->display.is_atomic, "Atomic mode-set not
> +supported\n");
>  	igt_require_intel(data->drm_fd);
>  	devid = intel_get_drm_devid(data->drm_fd);
> -	igt_require(intel_display_ver(devid) >= 9);
> +	igt_require_f(intel_display_ver(devid) >= 9, "Requires Intel display
> +version 9 or above\n");
Is this really needed, Skip statement is pretty self-explanatory. 
This might cause excessive logging. 
> 
>  	output = igt_get_single_output_for_pipe(&data->display, pipe);
> -	igt_require(output);
> +	igt_require_f(output, "Output-%s is not compatible with pipe-%s\n",
> +		      data->output->name, kmstest_pipe_name(pipe));
Same goes here. 
> 
>  	igt_output_set_pipe(output, pipe);
>  	primary = igt_output_get_plane_type(output,
> DRM_PLANE_TYPE_PRIMARY);
> --
> 2.34.1