[PATCH i-g-t] tests/intel/kms_dsc: Add meaningfull skip message
Pranay Samala
pranay.samala at intel.com
Mon Nov 25 03:24:20 UTC 2024
This patch adds a proper skip message which will be
easy to debug.
Signed-off-by: Pranay Samala <pranay.samala at intel.com>
---
tests/intel/kms_dsc.c | 36 ++++++++++++++++++++----------------
1 file changed, 20 insertions(+), 16 deletions(-)
diff --git a/tests/intel/kms_dsc.c b/tests/intel/kms_dsc.c
index 9b48caf76..65b0d262c 100644
--- a/tests/intel/kms_dsc.c
+++ b/tests/intel/kms_dsc.c
@@ -280,21 +280,6 @@ static void test_dsc(data_t *data, uint32_t test_type, int bpc,
data->output = output;
data->pipe = pipe;
- if (!is_dsc_supported_by_sink(data->drm_fd, data->output) ||
- !check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe) ||
- igt_get_output_max_bpc(data->drm_fd, output->name) < MIN_DSC_BPC)
- continue;
-
- if ((test_type & TEST_DSC_OUTPUT_FORMAT) &&
- (!is_dsc_output_format_supported(data->drm_fd, data->disp_ver,
- data->output, data->output_format)))
- continue;
-
- if ((test_type & TEST_DSC_FRACTIONAL_BPP) &&
- (!is_dsc_fractional_bpp_supported(data->disp_ver,
- data->drm_fd, data->output)))
- continue;
-
if (test_type & TEST_DSC_OUTPUT_FORMAT)
snprintf(&name[0][0], LEN, "-%s", kmstest_dsc_output_format_str(data->output_format));
if (test_type & TEST_DSC_FORMAT)
@@ -303,8 +288,27 @@ static void test_dsc(data_t *data, uint32_t test_type, int bpc,
snprintf(&name[2][0], LEN, "-%dbpc", data->input_bpc);
igt_dynamic_f("pipe-%s-%s%s%s%s", kmstest_pipe_name(data->pipe), data->output->name,
- &name[0][0], &name[1][0], &name[2][0])
+ &name[0][0], &name[1][0], &name[2][0]) {
+ if (!is_dsc_supported_by_sink(data->drm_fd, data->output) ||
+ !check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe) ||
+ igt_get_output_max_bpc(data->drm_fd, output->name) < MIN_DSC_BPC)
+ continue;
+
+ if ((test_type & TEST_DSC_OUTPUT_FORMAT) &&
+ (!is_dsc_output_format_supported(data->drm_fd, data->disp_ver,
+ data->output, data->output_format))) {
+ igt_skip("DSC %s output format not supported on pipe-%s\n",
+ kmstest_dsc_output_format_str(data->output_format),
+ kmstest_pipe_name(data->pipe));
+ continue;
+ }
+
+ if ((test_type & TEST_DSC_FRACTIONAL_BPP) &&
+ (!is_dsc_fractional_bpp_supported(data->disp_ver,
+ data->drm_fd, data->output)))
+ continue;
update_display(data, test_type);
+ }
if (data->limited)
break;
--
2.34.1
More information about the igt-dev
mailing list