[PATCH 2/3] tests/kms_async_flips: Skip async flips on joiner output
Sharma, Swati2
swati2.sharma at intel.com
Tue Nov 26 12:11:27 UTC 2024
LGTM
Reviewed-by: Swati Sharma <swati2.sharma at intel.com>
On 25-11-2024 10:04 pm, Jeevan B wrote:
> From: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
>
> Async flips are disallowed with joiner, but the test commit still
> goes through and causes failures. Update the tests to skip on
> joiner outputs.
>
> V2: Skip tests only on joiner outputs (Kunal).
> V3: Add a todo to remove workaround when async flips with joiner is
> supported in kernel.
> V4: Add proper FIXME, improve log message and
> move igt_is_joiner mode to library (Swati).
>
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
> Signed-off-by: Jeevan B <jeevan.b at intel.com>
> Reviewed-by: Kunal Joshi <kunal1.joshi at intel.com>
> ---
> tests/kms_async_flips.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index 5dec71291..3ce6e18d7 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -653,6 +653,12 @@ static void run_test(data_t *data, void (*test)(data_t *))
> data->allow_fail = false;
> data->modifier = default_modifier(data);
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data->pipe), data->output->name) {
> + /*
> + * FIXME: joiner+async flip is busted currently in KMD.
> + * Remove this check once the issues are fixed in KMD.
> + */
> + igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
> + "Skipping, async flip not supported on joiner mode\n");
> test_init_fbs(data);
> test(data);
> }
> @@ -674,8 +680,16 @@ static void run_test_with_modifiers(data_t *data, void (*test)(data_t *))
> igt_dynamic_f("pipe-%s-%s-%s", kmstest_pipe_name(data->pipe),
> data->output->name,
> igt_fb_modifier_name(data->modifier)) {
> - test_init_fbs(data);
> - test(data);
> + /*
> + * FIXME: joiner+async flip is busted currently in KMD.
> + * Remove this check once the issues are fixed in KMD.
> + */
> + igt_skip_on_f(is_joiner_mode(data->drm_fd,
> + data->output),
> + "Skipping, async flip not supported "
> + "on joiner mode\n");
> + test_init_fbs(data);
> + test(data);
> }
> }
> }
More information about the igt-dev
mailing list