[PATCH i-g-t 1/2] tests/kms_scaling_modes: Add informative messages for skipped scaling mode tests

[Samala, Pranay]

Hi Rama,

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Naladala
> Ramanaidu
> Sent: Thursday, November 28, 2024 12:35 AM
> To: igt-dev at lists.freedesktop.org
> Cc: B S, Karthik <karthik.b.s at intel.com>; Naladala, Ramanaidu
> <ramanaidu.naladala at intel.com>
> Subject: [PATCH i-g-t 1/2] tests/kms_scaling_modes: Add informative messages
> for skipped scaling mode tests
> 
> Add `igt_info` messages to provide more context when skipping outputs that do
> not support scaling mode. Include `igt_info` messages to indicate when invalid
> pipe/output combinations are skipped.
> 
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
> ---
>  tests/kms_scaling_modes.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c index
> 5fd34c4b2..dd2c6426c 100644
> --- a/tests/kms_scaling_modes.c
> +++ b/tests/kms_scaling_modes.c
> @@ -117,12 +117,17 @@ static void test_scaling_mode(data_t *data, uint32_t
> flags)
>  	for_each_pipe_with_valid_output(display, pipe, output) {
>  		igt_display_reset(display);
> 
> -		if (!has_scaling_mode(output))
> +		if (!has_scaling_mode(output)) {
> +			igt_info("Output %s does not support scaling mode.\n",
> +				  igt_output_name(output));
Alignment should match open parenthesis

>  			continue;
> +		}
> 
>  		igt_output_set_pipe(output, pipe);
> -		if (!intel_pipe_output_combo_valid(display))
> +		if (!intel_pipe_output_combo_valid(display)) {
> +			igt_info("Skipping invalid pipe/output combination.\n");
Is this really needed, Skip statement in intel_pipe_output_combo_valid() 
is self-explanatory.

>  			continue;
> +		}
> 
>  		igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe),
> igt_output_name(output))
>  			test_scaling_mode_on_output(display, pipe, output,
> flags);
> --
> 2.43.0