[i-g-t,v2,4/4] runner/executor: Inform about terminating

Ryszard Knop rk at dragonic.eu
Wed Nov 27 14:32:25 UTC 2024


LGTM

Reviewed-by: Ryszard Knop <rk at dragonic.eu>

On Wed, 2024-11-20 at 19:32 +0100, Kamil Konieczny wrote:
> Create a message before terminating a running test and
> inform user what is a cause.
> 
> Signed-off-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
>  runner/executor.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/runner/executor.c b/runner/executor.c
> index 5a4c2e1b2..316b81575 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -1359,8 +1359,12 @@ static int monitor_output(pid_t child,
>  
>  				aborting = true;
>  				killed = SIGQUIT;
> -				if (!kill_child(killed, child))
> +				if (!kill_child(killed, child)) {
> +					errf("Error terminating child with %s, errno=%d\n",
> +					     killed == SIGQUIT ? "SIGQUIT" : "SIGKILL", errno);
> +
>  					return -1;
> +				}
>  				time_killed = time_now;
>  
>  				continue;


More information about the igt-dev mailing list