[PATCH i-g-t] tests/intel/kms_dsc: Add meaningfull skip message

[Kamil Konieczny]

Hi,
On 2024-11-25 at 17:36:16 +0000, B, Jeevan wrote:
> > -----Original Message-----
> > From: Samala, Pranay <pranay.samala at intel.com>
> > Sent: Monday, November 25, 2024 8:54 AM
> > To: igt-dev at lists.freedesktop.org
> > Cc: B S, Karthik <karthik.b.s at intel.com>; Sharma, Swati2
> > <swati2.sharma at intel.com>; B, Jeevan <jeevan.b at intel.com>; Lattannavar,
> > Sameer <sameer.lattannavar at intel.com>; Samala, Pranay
> > <pranay.samala at intel.com>
> > Subject: [PATCH i-g-t] tests/intel/kms_dsc: Add meaningfull skip message
> > 
> > This patch adds a proper skip message which will be easy to debug.

After this description I would expect only skip messages will
change but later on you did more then this. You should describe
all changes made by a patch, see CONTRIBUTE.md for some pointers.

> > 
> > Signed-off-by: Pranay Samala <pranay.samala at intel.com>
> > ---
> >  tests/intel/kms_dsc.c | 36 ++++++++++++++++++++----------------
> >  1 file changed, 20 insertions(+), 16 deletions(-)
> > 

...cut...

> > +			if ((test_type & TEST_DSC_FRACTIONAL_BPP) &&
> > +			    (!is_dsc_fractional_bpp_supported(data->disp_ver,
> > +							      data->drm_fd,
> > data->output)))
> > +				continue;
> >  			update_display(data, test_type);
> > +		}
> This introduces new dynamic subtests, 
> LGTM. 
> 
> Reviewed-by: Jeevan B <jeevan.b at intel.com>

Please split this into adding meaningfull messages and second patch
for introducing new dynamic subtests.

Regards,
Kamil

> > 
> >  		if (data->limited)
> >  			break;
> > --
> > 2.34.1
>