[PATCH i-g-t] tests/intel/xe_tlb: Print tlb inval counts on failure

Cavitt, Jonathan jonathan.cavitt at intel.com
Tue Oct 8 21:44:07 UTC 2024


-----Original Message-----
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Nirmoy Das
Sent: Tuesday, October 8, 2024 1:22 PM
To: igt-dev at lists.freedesktop.org
Cc: Das, Nirmoy <nirmoy.das at intel.com>; kamil.konieczny at linux.intel.com; Ch, Sai Gowtham <sai.gowtham.ch at intel.com>
Subject: [PATCH i-g-t] tests/intel/xe_tlb: Print tlb inval counts on failure
> 
> Print tlb inval counts on failure with igt_assert_lt_u64()
> 
> Cc: kamil.konieczny at linux.intel.com
> Cc: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>

Sounds good to me!

Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  tests/intel/xe_tlb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/xe_tlb.c b/tests/intel/xe_tlb.c
> index 8104e45d8..15d89931c 100644
> --- a/tests/intel/xe_tlb.c
> +++ b/tests/intel/xe_tlb.c
> @@ -116,7 +116,7 @@ static void tlb_invalidation(int fd, struct drm_xe_engine_class_instance *eci)
>  	tlb_pos = xe_gt_stats_get_count(fd, eci->gt_id, stat);
>  	igt_assert_eq(data1->data, value1);
>  	igt_assert_eq(data2->data, value2);
> -	igt_assert(tlb_pos > tlb_pre);
> +	igt_assert_lt_u64(tlb_pre, tlb_pos);
>  
>  	syncobj_destroy(fd, sync[0].handle);
>  	syncobj_destroy(fd, syncobj);
> -- 
> 2.46.0
> 
> 


More information about the igt-dev mailing list