RE: ✗ GitLab.Pipeline: warning for intel: igt_draw and intel_bufops improvements

[Piecielska, Katarzyna]

In test documentation you are pointing to:
+/**
+ * TEST: gem draw
+ * Category: GEM
+ * Description: Tests whether the igt_draw library actually works.
+ * Driver requirement: i915
+ * Functionality: tiling
+ * Test category: functionality test
+ */
Please add Mega feature field as well as this is mandatory. For 'Driver requirement' is it strange as I see that used in many tests.

Kasia

-----Original Message-----
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Zbigniew Kempczynski
Sent: Friday, October 11, 2024 9:00 AM
To: Ville Syrjälä <ville.syrjala at linux.intel.com>
Cc: igt-dev at lists.freedesktop.org
Subject: Re: ✗ GitLab.Pipeline: warning for intel: igt_draw and intel_bufops improvements

On Thu, Oct 10, 2024 at 10:41:13PM +0300, Ville Syrjälä wrote:
> On Mon, Oct 07, 2024 at 03:39:24PM -0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: intel: igt_draw and intel_bufops improvements
> > URL   : https://patchwork.freedesktop.org/series/139556/
> > State : warning
> > 
> > == Summary ==
> > 
> > Pipeline status: FAILED.
> > 
> > see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/1285113 for the overview.
> > 
> > build:tests-debian-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/64744864):
> >   [1900/1907] Generating xe_tests.rst with a custom command.
> >   [1901/1907] Generating kms_tests.rst with a custom command.
> >   [1902/1907] Compiling C object 'runner/527aa9f@@runner_test at exe/runner_tests.c.o'.
> >   ninja: build stopped: subcommand failed.
> >   ninja: Entering directory `build'
> >   [1/848] Generating version.h with a custom command.
> >   [2/8] Linking target runner/runner_test.
> >   [3/8] Linking target assembler/intel-gen4asm.
> >   [4/8] Generating intel-ci-tests with a custom command.
> >   FAILED: docs/testplan/intel-ci-tests 
> >   /builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/i915_test_config.json /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json /builds/gfx-ci/igt-ci-tags/tests/intel/xe_test_config.json --intelci-testlist docs/testplan/intel-ci-tests
> >   /builds/gfx-ci/igt-ci-tags/tests/intel/gem_draw.c:10: Error: unrecognized line. Need to add field at /builds/gfx-ci/igt-ci-tags/tests/intel/i915_test_config.json?
> 
> Do I need to add something? Who the heck knows?
> Can the person who added all this crap provide the patch to fix it?
> 
> We've reached a point where making any changes to igt means spending 
> 10% of time on actual work, and the remaining 90% is spent dealing 
> with the idiotic "documentation" stuff.

I've checked gem_draw.c and it seems it is i915 specific. Instead of adding 'Driver requirement' field to i915_test_config.json, remove it from from gem_draw.c.

--
Zbigniew

> 
> --
> Ville Syrjälä
> Intel