[PATCH i-g-t 4/4] lib/intel: Documnent gem_can_store_dword()

[Kamil Konieczny]

Hi Ville,
On 2024-10-02 at 13:45:15 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Add basic docs for gem_class_can_store_dword() and
> gem_can_store_dword().
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  lib/igt_gt.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index b8faf2b7bd09..a8f7f4431d1c 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -667,6 +667,13 @@ static bool gem_store_dword_needs_physical(const struct intel_device_info *info)
>  	}
>  }
>  
> +/**
> + * gem_class_can_store_dword:
> + * @fd: open i915 drm file descriptor
> + * @class: engine class
> + *
> + * Is the MI_STORE_DWORD instruction actually usable?

Same here, instead of a question just write: True if ...
or
Returns true if ...

> + */
>  bool gem_class_can_store_dword(int fd, int class)
>  {
>  	uint16_t devid = intel_get_drm_devid(fd);
> @@ -685,6 +692,13 @@ bool gem_class_can_store_dword(int fd, int class)
>  	return true;
>  }
>  
> +/**
> + * gem_can_store_dword:
> + * @fd: open i915 drm file descriptor
> + * @engine: engine
> + *
> + * Is the MI_STORE_DWORD instruction actually usable?

Same here. With this
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>


> + */
>  bool gem_can_store_dword(int fd, unsigned int engine)
>  {
>  	return gem_class_can_store_dword(fd,
> -- 
> 2.45.2
>