[PATCH i-g-t 2/3] tests/intel/xe_query: Add debug messsage with calculated refclock

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Oct 11 16:55:03 UTC 2024


Hi Lucas,
On 2024-10-10 at 22:05:06 -0500, Lucas De Marchi wrote:

small type in subject:

tests/intel/xe_query: Add debug messsage with calculated refclock
----------------------------------^^^
s/messsage/message/

with this fixed
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> When debugging new hardware, it's useful to check the refclock matches
> the expectation. Calculated the expected reflock and print it for quick
> check. Eventually this could be a test on its own if the err is stable.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  tests/intel/xe_query.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/xe_query.c b/tests/intel/xe_query.c
> index 9e0fa93dd..87ddb58bb 100644
> --- a/tests/intel/xe_query.c
> +++ b/tests/intel/xe_query.c
> @@ -708,7 +708,7 @@ __engine_cycles(int fd, struct drm_xe_engine_class_instance *hwe)
>  {
>  	struct drm_xe_query_engine_cycles ts1 = {};
>  	struct drm_xe_query_engine_cycles ts2 = {};
> -	uint64_t delta_cpu, delta_cs, delta_delta;
> +	uint64_t delta_cpu, delta_cs, delta_delta, calc_freq;
>  	unsigned int exec_queue;
>  	int i, usable = 0;
>  	igt_spin_t *spin;
> @@ -770,7 +770,10 @@ __engine_cycles(int fd, struct drm_xe_engine_class_instance *hwe)
>  			delta_cs = (((1 << ts2.width) - ts2.engine_cycles) + ts1.engine_cycles) *
>  				   NSEC_PER_SEC / eng_ref_clock;
>  
> -		igt_debug("freq %u Hz\n", eng_ref_clock);
> +		calc_freq = (ts2.engine_cycles - ts1.engine_cycles) * NSEC_PER_SEC / delta_cpu;
> +
> +		igt_debug("freq %u Hz, calc_freq %"PRIu64" Hz, err %.3f%%\n", eng_ref_clock,
> +			  calc_freq, fabs((double)calc_freq - eng_ref_clock) * 100 / eng_ref_clock);
>  		igt_debug("delta_cpu[%"PRIu64"], delta_cs[%"PRIu64"]\n",
>  			  delta_cpu, delta_cs);
>  
> -- 
> 2.46.2
> 


More information about the igt-dev mailing list