[PATCH] tests/xe_exec_sip: increase timeout margin for tests

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon Oct 14 09:53:08 UTC 2024


Hi Andrzej,
On 2024-10-11 at 15:36:22 +0200, Andrzej Hajda wrote:
> In case engine reset happens 4s timeout margin sometimes is not enough and test
> fails. It happens mostly on LNL due to devcoredump creation.

Could that mension about 'devcoredump creation time' be also put in comment
in a test?

> On CI it does not pass 5s, lets increase it to 8s to be on safe side.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda at intel.com>


With or without it,
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/intel/xe_exec_sip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/xe_exec_sip.c b/tests/intel/xe_exec_sip.c
> index 2294468c2983..50265c0c6a45 100644
> --- a/tests/intel/xe_exec_sip.c
> +++ b/tests/intel/xe_exec_sip.c
> @@ -274,8 +274,8 @@ static void test_sip(enum shader_type shader_type, enum sip_type sip_type,
>  
>  	vm_id = xe_vm_create(fd, 0, 0);
>  
> -	/* Get timeout for job, and add 4s to ensure timeout processes in subtest. */
> -	timeout = xe_sysfs_get_job_timeout_ms(fd, eci) + 4ull * MSEC_PER_SEC;
> +	/* Get timeout for job, and add 8s to ensure timeout processes in subtest. */
> +	timeout = xe_sysfs_get_job_timeout_ms(fd, eci) + 8ull * MSEC_PER_SEC;
>  	timeout *= NSEC_PER_MSEC;
>  	timeout *= igt_run_in_simulation() ? 10 : 1;
>  
> 
> ---
> base-commit: cc3fa4e36bb0445565f40f989540b9deacb92e12
> change-id: 20241011-xe_exec_sip_increase_timeout_margin-a64bcb49752d
> 
> Best regards,
> -- 
> Andrzej Hajda <andrzej.hajda at intel.com>
> 


More information about the igt-dev mailing list