[PATCH] tests/intel/xe_exec_reset: Explicitly declare exec

Cavitt, Jonathan jonathan.cavitt at intel.com
Mon Oct 14 21:50:53 UTC 2024


-----Original Message-----
From: Dixit, Ashutosh <ashutosh.dixit at intel.com> 
Sent: Monday, October 14, 2024 2:46 PM
To: Cavitt, Jonathan <jonathan.cavitt at intel.com>
Cc: igt-dev at lists.freedesktop.org; Gupta, saurabhg <saurabhg.gupta at intel.com>; Zuo, Alex <alex.zuo at intel.com>; Saarinen, Jani <jani.saarinen at intel.com>
Subject: Re: [PATCH] tests/intel/xe_exec_reset: Explicitly declare exec
> 
> On Mon, 14 Oct 2024 14:39:36 -0700, Jonathan Cavitt wrote:
> >
> > diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
> > index b5d5f43eab..fdfefa91cc 100644
> > --- a/tests/intel/xe_exec_reset.c
> > +++ b/tests/intel/xe_exec_reset.c
> > @@ -628,7 +628,7 @@ static void submit_jobs(struct gt_thread_data *t)
> >			.engine_instance = 0,
> >			.gt_id = 0,
> >		};
> > -		struct drm_xe_exec exec;
> > +		struct drm_xe_exec exec = {};
> >		int ret;
> >
> 
> How about
> 
>       struct drm_xe_exec exec = {
>                 .num_batch_buffer = 1,
>                 .address = addr,
>         };
> 
> And delete the assignments below?

Good catch!
I'll apply this change shortly and change the commit message
to reflect the new implementation.
-Jonathan Cavitt

> 
> >		/* GuC IDs can get exhausted */
> > --
> > 2.43.0
> >
> 


More information about the igt-dev mailing list