[PATCH i-g-t 1/2] tests/kms_flip.c: Updating the skip message

Naladala, Ramanaidu ramanaidu.naladala at intel.com
Thu Oct 17 08:53:10 UTC 2024


Hi Pranay,

-----Original Message-----
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Pranay Samala
Sent: Tuesday, October 15, 2024 10:49 PM
To: igt-dev at lists.freedesktop.org
Cc: B S, Karthik <karthik.b.s at intel.com>; Lattannavar, Sameer <sameer.lattannavar at intel.com>; Samala, Pranay <pranay.samala at intel.com>
Subject: [PATCH i-g-t 1/2] tests/kms_flip.c: Updating the skip message

Debugging would be easier if we had logs available for test failures and skips. This patch rephrases the skip message for better understanding.

Signed-off-by: Pranay Samala <pranay.samala at intel.com>
---
 tests/kms_flip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c index cbabbe74f..88cd41083 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1896,7 +1896,7 @@ static void run_pair(int duration, int flags)
 
 	/* If we have fewer than 2 connected outputs then we won't have any
 	 * configuration at all. So skip in that case. */
-	igt_require_f(modes, "At least two displays required\n");
+	igt_require_f(modes, "At least two displays with same modes are 
+required\n");

Code changes are LGTM. Make CI green before merge into upstream.
LGTM,
Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
 
 	if (duration) {
 		duration = duration * 1000 / modes;
--
2.34.1



More information about the igt-dev mailing list