[PATCH i-g-t] oa/i915: Add ARL standlone oa files

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu Oct 17 11:06:35 UTC 2024


Hi José,
On 2024-10-15 at 11:17:21 -0700, José Roberto de Souza wrote:
> There is suficient differences between generated ARL OA files and
> MTL ones for us to generated and split ARL to its own files.
> 
> Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> ---
>  lib/i915/perf-configs/guids.xml            |   435 +
>  lib/i915/perf-configs/mdapi-xml-convert.py |     5 +-
>  lib/i915/perf-configs/oa-arlgt1.xml        | 34793 +++++++++++
>  lib/i915/perf-configs/oa-arlgt2.xml        | 58762 +++++++++++++++++++

Could this change be splitted into two? ARLGT1 and ARLGT2?
So it will be two 2,5MB each, not one big 5MB?
It is still much but if you need it let it be.

>  lib/i915/perf-configs/oa_guid_registry.py  |     3 +-
>  lib/i915/perf-configs/update-guids.py      |     1 +
>  lib/i915/perf.c                            |     6 +-
>  lib/meson.build                            |     1 +
>  8 files changed, 94001 insertions(+), 5 deletions(-)
>  create mode 100644 lib/i915/perf-configs/oa-arlgt1.xml
>  create mode 100644 lib/i915/perf-configs/oa-arlgt2.xml

imho please start with prefix 'lib/i915/perf: ' and also
write 'OA' in capital letters, so

[PATCH i-g-t] lib/i915/perf: Add ARL standlone OA files

Regards,
Kamil

> [...cut...]


More information about the igt-dev mailing list