[i-g-t,v1] tests/kms_async_flips: Skip Async flips on joiner output
Joshi, Kunal1
kunal1.joshi at intel.com
Thu Oct 24 09:34:00 UTC 2024
Hello Santhosh,
On 23-10-2024 08:46, Santhosh Reddy Guddati wrote:
> Async flips are disallowed with joiner, but the test commit still
> goes through and causes failures. Update the tests to skip on
> joiner outputs.
>
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
> ---
> tests/kms_async_flips.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index 5dec71291..37075bb4a 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -686,18 +686,32 @@ static data_t data;
> igt_main
> {
> int i;
> + int max_dotclock = 0;
> + drmModeModeInfo mode;
>
> igt_fixture {
> data.drm_fd = drm_open_driver_master(DRIVER_ANY);
> kmstest_set_vt_graphics_mode();
> igt_display_require(&data.display, data.drm_fd);
> igt_display_require_output(&data.display);
> + max_dotclock = igt_get_max_dotclock(data.drm_fd);
>
> igt_require_f(igt_has_drm_cap(data.drm_fd, DRM_CAP_ASYNC_PAGE_FLIP),
> "Async Flip is not supported\n");
>
> if (is_intel_device(data.drm_fd))
> data.bops = buf_ops_create(data.drm_fd);
> + for_each_connected_output(&data.display, data.output) {
> + drmModeConnector *connector = data.output->config.connector;
> +
> + igt_skip_on_f(
> + bigjoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode) ||
> + ultrajoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode) ||
> + igt_has_force_joiner_debugfs(data.drm_fd, data.output->name),
> + "Skipping test on output %s as async flip disallowed with joiner mode\n",
> + data.output->name
> + );
> + }
Please have this check at test level and only exclude big joiner outputs,
Test should run on non bigjoiner outputs.
> }
>
> igt_describe("Verify the async flip functionality and the fps during async flips");
More information about the igt-dev
mailing list