[PATCH i-g-t 01/14] lib/igt_draw: Use void* where appopriate

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Tue Oct 29 14:44:18 UTC 2024


Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 4.10.2024 13.41, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Use void* instead of uint32_t* when we don't care about the
> element size.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>   lib/igt_draw.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index 97a7e6b375fb..3ebfaad6ef31 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -446,7 +446,7 @@ static void draw_rect_ptr_tiled(void *ptr, uint32_t stride, uint32_t tiling,
>   static void draw_rect_mmap_cpu(int fd, struct buf_data *buf, struct rect *rect,
>   			       uint32_t tiling, uint32_t swizzle, uint32_t color)
>   {
> -	uint32_t *ptr;
> +	void *ptr;
>   
>   	gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_CPU,
>   		       I915_GEM_DOMAIN_CPU);
> @@ -481,7 +481,7 @@ static void draw_rect_mmap_cpu(int fd, struct buf_data *buf, struct rect *rect,
>   static void draw_rect_mmap_gtt(int fd, struct buf_data *buf, struct rect *rect,
>   			       uint32_t color)
>   {
> -	uint32_t *ptr;
> +	void *ptr;
>   
>   	gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
>   		       I915_GEM_DOMAIN_GTT);
> @@ -497,7 +497,7 @@ static void draw_rect_mmap_gtt(int fd, struct buf_data *buf, struct rect *rect,
>   static void draw_rect_mmap_wc(int fd, struct buf_data *buf, struct rect *rect,
>   			      uint32_t tiling, uint32_t swizzle, uint32_t color)
>   {
> -	uint32_t *ptr;
> +	void *ptr;
>   
>   	if (is_i915_device(fd)) {
>   		gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,



More information about the igt-dev mailing list