[PATCH i-g-t] tests/xe_exec_comput_mode: Use valid exec queue for bind

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu Oct 31 15:04:40 UTC 2024


Hi Zbigniew,
On 2024-10-31 at 08:36:04 +0100, Zbigniew Kempczyński wrote:
> Using gt_id as exec queue for binding is wrong and it works by accident
> because bcs engine used in the subtest reside on tile 0. But trying
> to run the test on engine which resides on different tile just fails.
> Lets use default binding engine for this.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>

This is documented in lib header as exec queue, not as gt, so LGTM

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/intel/xe_exec_compute_mode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/xe_exec_compute_mode.c b/tests/intel/xe_exec_compute_mode.c
> index e49633ace8..8fba9daef7 100644
> --- a/tests/intel/xe_exec_compute_mode.c
> +++ b/tests/intel/xe_exec_compute_mode.c
> @@ -472,7 +472,7 @@ static void lr_mode_workload(int fd)
>  							ALLOC_STRATEGY_LOW_TO_HIGH);
>  
>  	sync.addr = to_user_pointer(&vm_sync);
> -	xe_vm_bind_async(fd, vm, engine->instance.gt_id, bo, 0, spin_addr, bo_size, &sync, 1);
> +	xe_vm_bind_async(fd, vm, 0, bo, 0, spin_addr, bo_size, &sync, 1);
>  	xe_wait_ufence(fd, &vm_sync, USER_FENCE_VALUE, 0, NSEC_PER_SEC);
>  
>  	xe_spin_init_opts(spin, .addr = spin_addr, .write_timestamp = true);
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list