[PATCH i-g-t 2/2] lib/intel_device_info: use dedicated macro for struct pci_id_match init

Dixit, Ashutosh ashutosh.dixit at intel.com
Tue Sep 3 20:55:38 UTC 2024


On Mon, 02 Sep 2024 06:49:07 -0700, Jani Nikula wrote:
>
> Now that we can pass our own macros to the INTEL_*_IDS() and XE_*_IDS()
> macros, define a new macro INTEL_PCI_ID_INIT() for struct pci_id_match
> initialization with designated initializers.
>
> INTEL_VGA_DEVICE() is aimed at initializing kernel struct pci_device_id,
> and it's mostly just a coincidence that it can be used to initialize
> struct pci_id_match. Indeed, the member names are different, and the IGT
> usage has prevented the kernel from switching to designated
> initializers.

OK, understand what you mean since INTEL_VGA_DEVICE comes from kernel
headers. So this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>


More information about the igt-dev mailing list